Re: [patch 3/3] x25_create initializing socket data twice

[Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>]

akpm@xxxxxxxx wrote:
> 
> x25_create() [net/x25/af_x25.c] is calling sock_init_data() twice ...  once
> indirectly via x25_alloc_socket() and a second time directly via
> sock_init_data(sock, sk);
> 
> while this might not look as critical as it seems, it can easily break
> stuff which assumes that sock_init_data() isn't called twice on the same
> socket.

As someone pointed out on LKML, this is broken since the sock_init_data
in x25_alloc_socket() is called with the first argument set to NULL.
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt