netdev
[Top] [All Lists]

Re: [PATCH] [NET]: Fix deletion of local addresses only varying in prefi

To: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [PATCH] [NET]: Fix deletion of local addresses only varying in prefix length
From: Patrick McHardy <kaber@xxxxxxxxx>
Date: Sat, 05 Mar 2005 02:11:20 +0100
Cc: Thomas Graf <tgraf@xxxxxxx>, davem@xxxxxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20050305010319.GB27804@xxxxxxxxxxxxxxxxxxx>
References: <20050304012003.GA31837@xxxxxxxxxxxxxx> <E1D78DN-0002te-00@xxxxxxxxxxxxxxxxxxxxxxxx> <20050304131419.GE31837@xxxxxxxxxxxxxx> <20050304233212.GA27421@xxxxxxxxxxxxxxxxxxx> <20050305002910.GJ31837@xxxxxxxxxxxxxx> <42290172.7020403@xxxxxxxxx> <20050305010319.GB27804@xxxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.7.5) Gecko/20050106 Debian/1.7.5-1
Herbert Xu wrote:
On Sat, Mar 05, 2005 at 01:46:42AM +0100, Patrick McHardy wrote:

I think that would be ok. Unrelated to this: for IFA_ADDRESS we don't
do an exact match, perhaps we should also do this for IFA_LOCAL for
consistency.


You mean that we do do an exact match for IFA_ADDRESS?

No, I meant that IFA_ADDRESS matches on exact prefixlen, but uses
inet_ifa_match() for comparing the addresses. In any case we should
keep the behaviour that no given prefix is a wildcard, but if a
prefix is given we could do something similar as for IFA_ADDRESS.

Regards
Patrick

<Prev in Thread] Current Thread [Next in Thread>