| To: | Patrick McHardy <kaber@xxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] [NET]: Fix deletion of local addresses only varying in prefix length |
| From: | Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> |
| Date: | Sat, 5 Mar 2005 12:03:19 +1100 |
| Cc: | Thomas Graf <tgraf@xxxxxxx>, davem@xxxxxxxxxxxxx, netdev@xxxxxxxxxxx |
| In-reply-to: | <42290172.7020403@xxxxxxxxx> |
| References: | <20050304012003.GA31837@xxxxxxxxxxxxxx> <E1D78DN-0002te-00@xxxxxxxxxxxxxxxxxxxxxxxx> <20050304131419.GE31837@xxxxxxxxxxxxxx> <20050304233212.GA27421@xxxxxxxxxxxxxxxxxxx> <20050305002910.GJ31837@xxxxxxxxxxxxxx> <42290172.7020403@xxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.5.6+20040907i |
On Sat, Mar 05, 2005 at 01:46:42AM +0100, Patrick McHardy wrote: > > I think that would be ok. Unrelated to this: for IFA_ADDRESS we don't > do an exact match, perhaps we should also do this for IFA_LOCAL for > consistency. You mean that we do do an exact match for IFA_ADDRESS? Yes that's exactly what Thomas is trying to fix for IFA_LOCAL. The only problem is that people may have come to depend on the "wildcard" match behaviour of IFA_LOCAL, i.e.: ip a a dev eth0 192.168.0.1/24 ip a d dev eth0 192.168.0.1 His proposal of encoding a wildcard bit in IFA_LOCAL's prefix length should solve the problem. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt |
| Previous by Date: | Re: [PATCH] [NET]: Fix deletion of local addresses only varying in prefix length, Herbert Xu |
|---|---|
| Next by Date: | Re: [PATCH] [NET]: Fix deletion of local addresses only varying in prefix length, Patrick McHardy |
| Previous by Thread: | Re: [PATCH] [NET]: Fix deletion of local addresses only varying in prefix length, Patrick McHardy |
| Next by Thread: | Re: [PATCH] [NET]: Fix deletion of local addresses only varying in prefix length, Patrick McHardy |
| Indexes: | [Date] [Thread] [Top] [All Lists] |