Re: r8169: panic on 2.6.11

[Francois Romieu <romieu@xxxxxxxxxxxxx>]

Jon Mason <jdmason@xxxxxxxxxx> :
[...]
> > @@ -2210,6 +2211,24 @@ rtl8169_rx_interrupt(struct net_device *
> >     pci_action(tp->pci_dev, le64_to_cpu(desc->addr),
> >         tp->rx_buf_sz, PCI_DMA_FROMDEVICE);
> >
> > +   if (pkt_size >= tp->rx_buf_sz) {
> > +    show_size = 1;
> > +    pkt_size = tp->rx_buf_sz;
> > +   }
> 
> Shouldn't the above be dev->mtu (instead of tp->rx_buf_sz), otherwise there 
> won't be enough room for ethernet header, CRC, etc.

There is no room left in the buffer. I want it to be translated into the
biggest skb_put() possible. tp->rx_buf_sz already account the headers (see
rtl8169_set_rxbufsize), no ?

At worst it is possible we are a bit pessimistic imho.

--
Ueimor