netdev
[Top] [All Lists]

Re: [PATCH 7/7] netpoll: avoid kfree_skb on packets with destructo

To: Matt Mackall <mpm@xxxxxxxxxxx>
Subject: Re: [PATCH 7/7] netpoll: avoid kfree_skb on packets with destructo
From: "David S. Miller" <davem@xxxxxxxxxxxxx>
Date: Thu, 3 Mar 2005 13:41:19 -0800
Cc: jgarzik@xxxxxxxxx, netdev@xxxxxxxxxxx, jmoyer@xxxxxxxxxx
In-reply-to: <20050303213911.GV3120@xxxxxxxxx>
References: <7.454130102@xxxxxxxxxxx> <8.454130102@xxxxxxxxxxx> <20050303130031.066f0862.davem@xxxxxxxxxxxxx> <42277ED6.4020707@xxxxxxxxx> <20050303132906.2b5d597f.davem@xxxxxxxxxxxxx> <20050303213911.GV3120@xxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Thu, 3 Mar 2005 13:39:11 -0800
Matt Mackall <mpm@xxxxxxxxxxx> wrote:

> The lock only happens if CONFIG_NETPOLL=y _and_ a netpoll client (eg
> netconsole) is registered on the device in question.

I actually missed that condition.  This is less intrusive then.
I'm actually ok with these changes therefore.

I'll merge these patches in (with the SKB leak fix of course)
and will push upstream once we work out how 2.6.x development
is going to process :-)

<Prev in Thread] Current Thread [Next in Thread>