netdev
[Top] [All Lists]

Re: [PATCH 7/7] netpoll: avoid kfree_skb on packets with destructo

To: "David S. Miller" <davem@xxxxxxxxxxxxx>
Subject: Re: [PATCH 7/7] netpoll: avoid kfree_skb on packets with destructo
From: Jeff Garzik <jgarzik@xxxxxxxxx>
Date: Thu, 03 Mar 2005 16:17:10 -0500
Cc: Matt Mackall <mpm@xxxxxxxxxxx>, netdev@xxxxxxxxxxx, jmoyer@xxxxxxxxxx
In-reply-to: <20050303130031.066f0862.davem@xxxxxxxxxxxxx>
References: <7.454130102@xxxxxxxxxxx> <8.454130102@xxxxxxxxxxx> <20050303130031.066f0862.davem@xxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3) Gecko/20040922
David S. Miller wrote:
On Thu, 03 Mar 2005 14:46:32 -0600
Matt Mackall <mpm@xxxxxxxxxxx> wrote:


Packets that have destructors should not be zapped here as that might
produce additional printk warnings via netconsole.

Signed-off-by: Matt Mackall <mpm@xxxxxxxxxxx>


Then where will they be freed, eh? :-)

This patch adds an SKB leak.  Since you've NULL'd out the list, any
SKB skipped will never be freed up at all.

Heh, I was just writing this same message.

On a related note... David, I would prefer if you merged up the netpoll stuff, since it touches mainly net/*

Is that cool w/ you?

        Jeff




<Prev in Thread] Current Thread [Next in Thread>