netdev
[Top] [All Lists]

Re: [PATCH] remove dead skb_iter code

To: "David S. Miller" <davem@xxxxxxxxxxxxx>
Subject: Re: [PATCH] remove dead skb_iter code
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 2 Mar 2005 22:07:35 +0000
Cc: Stephen Hemminger <shemminger@xxxxxxxx>, netdev@xxxxxxxxxxx
In-reply-to: <20050302102025.23f479f9.davem@xxxxxxxxxxxxx>
References: <20050302101035.61786113@xxxxxxxxxxxxxxxxx> <20050302102025.23f479f9.davem@xxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.4.1i
On Wed, Mar 02, 2005 at 10:20:25AM -0800, David S. Miller wrote:
> On Wed, 2 Mar 2005 10:10:35 -0800
> Stephen Hemminger <shemminger@xxxxxxxx> wrote:
> 
> > The code iterate over skb_frags is defined but not used by any
> > existing kernel code.
> > 
> > Signed-off-by: Stephen Hemminger <shemminger@xxxxxxxx>
> 
> Rusty and co.'s planned netfilter packet parsing code will use
> the iterators.  Send a patch to add a comment to this effect
> or something as I'm tired of folks trying to remove this code.
> :-)

Maybe because the removal is right.  This code is not dependent on
any networking internals so it can easily live in a netfilter support
module instead of bloating everyones kernels.


<Prev in Thread] Current Thread [Next in Thread>