netdev
[Top] [All Lists]

Re: [2.6.11-rc4-mm1 patch] fix buggy IEEE80211_CRYPT_* selects

To: Andrew Morton <akpm@xxxxxxxx>
Subject: Re: [2.6.11-rc4-mm1 patch] fix buggy IEEE80211_CRYPT_* selects
From: Jeff Garzik <jgarzik@xxxxxxxxx>
Date: Wed, 02 Mar 2005 16:07:20 -0500
Cc: bunk@xxxxxxxxx, netdev@xxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <20050302123829.51dbc44b.akpm@xxxxxxxx>
References: <20050223014233.6710fd73.akpm@xxxxxxxx> <20050226113123.GJ3311@xxxxxxxxx> <42256078.1040002@xxxxxxxxx> <20050302140833.GD4608@xxxxxxxxx> <42261004.4000501@xxxxxxxxx> <20050302123829.51dbc44b.akpm@xxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3) Gecko/20040922
Andrew Morton wrote:
Jeff Garzik <jgarzik@xxxxxxxxx> wrote:

Adrian Bunk wrote:

On Wed, Mar 02, 2005 at 01:43:04AM -0500, Jeff Garzik wrote:


Adrian Bunk wrote:


+       select CRYPTO
        select CRYPTO_AES
        ---help---
Include software based cipher suites in support of IEEE 802.11i (aka TGi, WPA, WPA2, WPA-PSK, etc.) for use with CCMP enabled networks.
@@ -54,10 +55,11 @@
        "ieee80211_crypt_ccmp".

config IEEE80211_CRYPT_TKIP
        tristate "IEEE 802.11i TKIP encryption"
        depends on IEEE80211
+       select CRYPTO
        select CRYPTO_MICHAEL_MIC


'select CRYPTO_AES' should 'select CRYPTO' automatically, I would hope.


This would result in a recursive dependency.

No, it wouldn't.  CRYPTO_AES depends on CRYPTO, which depends on nothing.



Thing is, CRYPTO_AES on only selectable on x86.

You're thinking about CRYPTO_AES_586. But looking at crypto/Kconfig, the dependencies are a bit weird:

config CRYPTO_AES
        tristate "AES cipher algorithms"
        depends on CRYPTO && !(X86 && !X86_64)
config CRYPTO_AES_586
        tristate "AES cipher algorithms (i586)"
        depends on CRYPTO && (X86 && !X86_64)


<Prev in Thread] Current Thread [Next in Thread>