|To:||Christoph Hellwig <hch@xxxxxxxxxxxxx>|
|Subject:||Re: [PATCH] tulip: de2104x, fix init. sections|
|From:||Jeff Garzik <jgarzik@xxxxxxxxx>|
|Date:||Wed, 02 Mar 2005 02:37:25 -0500|
|Cc:||"Randy.Dunlap" <randy.dunlap@xxxxxxxxxxx>, netdev@xxxxxxxxxxx, torvalds <torvalds@xxxxxxxx>, akpm <akpm@xxxxxxxx>|
|References:||<20050301214438.4653810e.randy.dunlap@xxxxxxxxxxx> <422558B2.6020105@xxxxxxxxx> <20050302072510.GA12464@xxxxxxxxxxxxx> <42256B89.2000104@xxxxxxxxx> <20050302073255.GA12859@xxxxxxxxxxxxx>|
|User-agent:||Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3) Gecko/20040922|
Christoph Hellwig wrote:
On Wed, Mar 02, 2005 at 02:30:17AM -0500, Jeff Garzik wrote:When someone proves this is possible, I will accept the code change. I doubt this will ever happen, for two reasons:1) Hotplug PCI slots are highly likely to choke on the 2104x's very early and slightly weird PCI hardware implementation.2) It's an ancient card and nobody will ever bother trying to hotplug it.No, it's a matter of correctness. The pci core can call ->probe all the time and every driver must be prepared. Even if no one tries it physically it's easily done with Greg's fake hotplug driver.
The change can be made when it's actually useful to someone. Making janitors and Christoph happy is not a good enough reason in my book.
|<Prev in Thread]||Current Thread||[Next in Thread>|
|Previous by Date:||Re: [PATCH] tulip: de2104x, fix init. sections, Christoph Hellwig|
|Next by Date:||Re: [PATCH] tulip: de2104x, fix init. sections, Jeff Garzik|
|Previous by Thread:||Re: [PATCH] tulip: de2104x, fix init. sections, Christoph Hellwig|
|Next by Thread:||Re: [PATCH] tulip: de2104x, fix init. sections, Jeff Garzik|
|Indexes:||[Date] [Thread] [Top] [All Lists]|