| To: | Jeff Garzik <jgarzik@xxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] tulip: de2104x, fix init. sections |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Wed, 2 Mar 2005 07:25:10 +0000 |
| Cc: | "Randy.Dunlap" <randy.dunlap@xxxxxxxxxxx>, netdev@xxxxxxxxxxx, torvalds <torvalds@xxxxxxxx>, akpm <akpm@xxxxxxxx> |
| In-reply-to: | <422558B2.6020105@xxxxxxxxx> |
| References: | <20050301214438.4653810e.randy.dunlap@xxxxxxxxxxx> <422558B2.6020105@xxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.4.1i |
On Wed, Mar 02, 2005 at 01:09:54AM -0500, Jeff Garzik wrote: > Randy.Dunlap wrote: > >tulip/de2104x: some __devinit functions were calling __init > > functions, made the latter __devinit also; > > Should go the other way: all the stuff in de2104x should be __init, not > __devinit. > > Nobody ever hotplugs a de2104x. How comes that you want to dictate what cards I put into my hotplug PCI slots? |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] tulip: de2104x, fix init. sections, Linus Torvalds |
|---|---|
| Next by Date: | Re: [PATCH] tulip: de2104x, fix init. sections, Jeff Garzik |
| Previous by Thread: | Re: [PATCH] tulip: de2104x, fix init. sections, Linus Torvalds |
| Next by Thread: | Re: [PATCH] tulip: de2104x, fix init. sections, Jeff Garzik |
| Indexes: | [Date] [Thread] [Top] [All Lists] |