netdev
[Top] [All Lists]

Re: [PATCH] tulip: de2104x, fix init. sections

To: "Randy.Dunlap" <randy.dunlap@xxxxxxxxxxx>
Subject: Re: [PATCH] tulip: de2104x, fix init. sections
From: Jeff Garzik <jgarzik@xxxxxxxxx>
Date: Wed, 02 Mar 2005 01:09:54 -0500
Cc: netdev@xxxxxxxxxxx, torvalds <torvalds@xxxxxxxx>, akpm <akpm@xxxxxxxx>
In-reply-to: <20050301214438.4653810e.randy.dunlap@xxxxxxxxxxx>
References: <20050301214438.4653810e.randy.dunlap@xxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3) Gecko/20040922
Randy.Dunlap wrote:
tulip/de2104x: some __devinit functions were calling __init
  functions, made the latter __devinit also;

Should go the other way: all the stuff in de2104x should be __init, not __devinit.

Nobody ever hotplugs a de2104x.

        Jeff




<Prev in Thread] Current Thread [Next in Thread>