netdev
[Top] [All Lists]

Re: Understanding the reason for placing a tcp_sock on stack in tcp netw

To: Stephen Torri <storri@xxxxxxxxx>
Subject: Re: Understanding the reason for placing a tcp_sock on stack in tcp network functions
From: Arnaldo Carvalho de Melo <arnaldo.melo@xxxxxxxxx>
Date: Tue, 1 Mar 2005 07:13:48 -0300
Cc: netdev <netdev@xxxxxxxxxxx>
Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:references; b=uNyMziy6JVdHC4Z4wNElXV+kXCvdAMLKOgygjI+HFHYCBYpRmHl1pX2Tm2AVTl6ZCqMxbHkKAi6GwrfjIBf8P6jPjkeIX7J1r3etHlx88w/mkNquTEm5BaYdUMtzqbgFDj0UeFLene6yecBRYUE0yJSURkO3Zwpinfs5cKk1tmA=
In-reply-to: <1109638277.9693.15.camel@xxxxxxxxxxxxxx>
References: <1109638277.9693.15.camel@xxxxxxxxxxxxxx>
Reply-to: acme@xxxxxxxxxxxxxxxx
Sender: netdev-bounce@xxxxxxxxxxx
This is not the case for at least some of these functions:

ChangeSet@xxxxxxxxxxx, 2005-02-22 10:48:28-08:00, acme@xxxxxxxxxxxxxxxx
  [TCP]: Fix excessive stack usage resulting in OOPS with 4KSTACKS.

  Various routines were putting a full struct tcp_sock on
  the local stack.  What they really wanted was a subset
  of this information when doing TCP options processing
  when we only have a mini-socket (for example in SYN-RECVD
  and TIME_WAIT states).

  Therefore pull out the needed information into a sub-struct
  and use that in the TCP options processing routines.

  Signed-off-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxxxxxxxx>
  Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>


On Mon, 28 Feb 2005 19:51:17 -0500, Stephen Torri <storri@xxxxxxxxx> wrote:
> I am trying to help out reducing the stack size of functions in the
> kernel. The function names and values below, with comments and
> questions, was obtained of the linux-2.6 kernel kept at bkbits.net when
> I did 'make checkstack'.

<Prev in Thread] Current Thread [Next in Thread>
  • Re: Understanding the reason for placing a tcp_sock on stack in tcp network functions, Arnaldo Carvalho de Melo <=