netdev
[Top] [All Lists]

Re: memory leak in net/sched/ipt.c?

To: jamal <hadi@xxxxxxxxxx>
Subject: Re: memory leak in net/sched/ipt.c?
From: Thomas Graf <tgraf@xxxxxxx>
Date: Wed, 23 Mar 2005 13:55:16 +0100
Cc: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>, Yichen Xie <yxie@xxxxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx, "David S. Miller" <davem@xxxxxxxxxxxxx>, kaber@xxxxxxxxx
In-reply-to: <1111581618.1088.72.camel@jzny.localdomain>
References: <E1DE44X-0001QM-00@gondolin.me.apana.org.au> <1111581618.1088.72.camel@jzny.localdomain>
Sender: netdev-bounce@xxxxxxxxxxx
* jamal <1111581618.1088.72.camel@xxxxxxxxxxxxxxxx> 2005-03-23 07:40
> On Wed, 2005-03-23 at 06:30, Herbert Xu wrote:
> > Yichen Xie <yxie@xxxxxxxxxxxxxxx> wrote:
> > > Is the memory block allocated on line 315 leaked every time tcp_ipt_dump 
> > > is called?
> > 
> > It seems to be.  This patch should free it.
> > 
> > Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>

> Just a small correction to patchlet:
> The second kfree should check for existence of t.

t is either valid or NULL so it's not a problem, unless you want
to create janitor work of course. ;->

<Prev in Thread] Current Thread [Next in Thread>