netdev
[Top] [All Lists]

Re: [RFC] TCP congestion schedulers

To: Stephen Hemminger <shemminger@xxxxxxxx>
Subject: Re: [RFC] TCP congestion schedulers
From: "David S. Miller" <davem@xxxxxxxxxxxxx>
Date: Thu, 17 Mar 2005 20:12:31 -0800
Cc: baruch@xxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20050314151726.532af90d@dxpl.pdx.osdl.net>
References: <421CF5E5.1060606@ev-en.org> <20050223135732.39e62c6c.davem@davemloft.net> <421D1E66.5090301@osdl.org> <421D30FA.1060900@ev-en.org> <20050225120814.5fa77b13@dxpl.pdx.osdl.net> <20050309210442.3e9786a6.davem@davemloft.net> <4230288F.1030202@ev-en.org> <20050310182629.1eab09ec.davem@davemloft.net> <20050311120054.4bbf675a@dxpl.pdx.osdl.net> <20050311201011.360c00da.davem@davemloft.net> <20050314151726.532af90d@dxpl.pdx.osdl.net>
Sender: netdev-bounce@xxxxxxxxxxx
On Mon, 14 Mar 2005 15:17:26 -0800
Stephen Hemminger <shemminger@xxxxxxxx> wrote:

> +/* Hook for advanced congestion control */
> +     struct tcp_ca_type *ca_proto;
> +#define TCP_CA_PRIV_SIZE     48
> +     u8               *ca_priv[TCP_CA_PRIV_SIZE];

An array of 48 pointers to "u8" eh? :-)

It happens to work, but you're using too much
space (specifically: 48 * sizeof(u8 *)) as a side effect.

Otherwise, the only comment I have is that we lose the tcp_diag
info.  Maybe create a "tcpdiag_put" method in there so we can
retain that.

I'm also not so religious anymore about retaining the existing
sysctl functionality to enable/disable ca algs.

<Prev in Thread] Current Thread [Next in Thread>