[Top] [All Lists]

Re: [15/*] [INET] Fix IPsec calculation in ip_append_data/ip6_append_dat

To: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [15/*] [INET] Fix IPsec calculation in ip_append_data/ip6_append_data
From: "David S. Miller" <davem@xxxxxxxxxxxxx>
Date: Tue, 15 Mar 2005 10:18:46 -0800
Cc: kuznet@xxxxxxxxxxxxx, yoshfuji@xxxxxxxxxxxxxx, kaber@xxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <>
References: <> <> <> <> <> <> <> <> <> <> <>
Sender: netdev-bounce@xxxxxxxxxxx
On Tue, 15 Mar 2005 20:19:04 +1100
Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote:

> This patch fixes the IPsec overhead handling in ip_append_data and
> ip6_append_data.  As it is they assume that the IPsec overhead is
> constant.  This is not true as with ESP the IPsec overhead will vary
> as the MTU varies.
> The result is that they may produce packets that will exceed the MTU
> when ESP is used.  Had it taken the trailer_len into account, it would
> have produced packets less than the real MTU.
> By switching to dst_mtu we get the optimal result.
> Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>

Looks nice.  Applied, thanks Herbert.

<Prev in Thread] Current Thread [Next in Thread>