|To:||Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>|
|Subject:||Re: [PATCH 3/3 XFRM]: Fix invalid key for lookup of cached bundles|
|From:||Patrick McHardy <kaber@xxxxxxxxx>|
|Date:||Sun, 6 Mar 2005 18:55:58 +0100 (CET)|
Fixed a missing pair of parentheses - ! has precedence over bitwise AND.
On Sun, 6 Mar 2005, Patrick McHardy wrote:
How about this one ? It keeps the DST_XFRM_TUNNEL flag and sets it on the first xfrm_dst in a bundle. I know it doesn't really belong there, but the alternatives are walking through the bundle an additional time or having xfrm_bundle_ok() return if it is a tunnel-mode bundle, but in that case we can only compare tos etc after the call to xfrm_bundle_ok(), which is rather expensive. I also moved the oif check to the checks performed only in transport mode, this reduces the number of cached bundles in tunnel mode to one per src/dst if the selector isn't narrower than that.
|<Prev in Thread]||Current Thread||[Next in Thread>|
|Previous by Date:||Re: Do you know the TCP stack? (127.x.x.x routing), Thomas Graf|
|Next by Date:||Re: [patch 1/3] fix buggy IEEE80211_CRYPT_* selects, Jeff Garzik|
|Previous by Thread:||Re: [PATCH 3/3 XFRM]: Fix invalid key for lookup of cached bundles, Patrick McHardy|
|Next by Thread:||Re: [PATCH 3/3 XFRM]: Fix invalid key for lookup of cached bundles, Herbert Xu|
|Indexes:||[Date] [Thread] [Top] [All Lists]|