netdev
[Top] [All Lists]

Re: [PATCH 1/7] netpoll: shorten carrier detect timeout

To: Patrick McHardy <kaber@xxxxxxxxx>
Subject: Re: [PATCH 1/7] netpoll: shorten carrier detect timeout
From: Matt Mackall <mpm@xxxxxxxxxxx>
Date: Sat, 5 Mar 2005 16:20:15 -0800
Cc: Jeff Garzik <jgarzik@xxxxxxxxx>, netdev@xxxxxxxxxxx, Jeff Moyer <jmoyer@xxxxxxxxxx>
In-reply-to: <422A4A38.4040303@trash.net>
References: <2.454130102@selenic.com> <422A4A38.4040303@trash.net>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.6+20040907i
On Sun, Mar 06, 2005 at 01:09:28AM +0100, Patrick McHardy wrote:
> Matt Mackall wrote:
> >Shorten carrier detect timeout to 4 seconds.
> 
> The carrier detection looks partially broken to me. The current logic
> detects an instantly available carrier as flaky because
> netif_carrier_ok() takes less than 1/10s. This patch does what
> I assume is intended, make sure the carrier is stable for 1/10s.

Looks ok, but I've been meaning to change the second loop to something
like msleep(). 

Did you try this with a card that otherwise goes into the wait?

-- 
Mathematics is the supreme nostalgia of our time.

<Prev in Thread] Current Thread [Next in Thread>