netdev
[Top] [All Lists]

Re: [PATCH 7/7] netpoll: avoid kfree_skb on packets with destructo

To: "David S. Miller" <davem@xxxxxxxxxxxxx>
Subject: Re: [PATCH 7/7] netpoll: avoid kfree_skb on packets with destructo
From: Jeff Garzik <jgarzik@xxxxxxxxx>
Date: Thu, 3 Mar 2005 16:33:41 -0500
Cc: mpm@xxxxxxxxxxx, netdev@xxxxxxxxxxx, jmoyer@xxxxxxxxxx
In-reply-to: <20050303132906.2b5d597f.davem@davemloft.net>
References: <7.454130102@selenic.com> <8.454130102@selenic.com> <20050303130031.066f0862.davem@davemloft.net> <42277ED6.4020707@pobox.com> <20050303132906.2b5d597f.davem@davemloft.net>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.4.1i
On Thu, Mar 03, 2005 at 01:29:06PM -0800, David S. Miller wrote:
> On Thu, 03 Mar 2005 16:17:10 -0500
> Jeff Garzik <jgarzik@xxxxxxxxx> wrote:
> 
> > Heh, I was just writing this same message.
> > 
> > On a related note...  David, I would prefer if you merged up the netpoll 
> > stuff, since it touches mainly net/*
> > 
> > Is that cool w/ you?
> 
> No problem.  I still don't like this code in that it adds a locking
> penalty to everyone just by virtue of enabling netpoll.  We've worked
> so hard with things like NETIF_F_LLTX to eliminate locking, so this
> would be a huge step backwards.

Agreed.

        Jeff




<Prev in Thread] Current Thread [Next in Thread>