netdev
[Top] [All Lists]

Re: pppoe and receive checksum offload

To: Stephen Hemminger <shemminger@xxxxxxxx>
Subject: Re: pppoe and receive checksum offload
From: "David S. Miller" <davem@xxxxxxxxxxxxx>
Date: Mon, 28 Feb 2005 15:32:28 -0800
Cc: mostrows@xxxxxxxxxxxxx, kuznet@xxxxxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <42235114.3070109@xxxxxxxx>
References: <20050224155906.73890361@xxxxxxxxxxxxxxxxx> <20050227202011.5ccefb22.davem@xxxxxxxxxxxxx> <42235114.3070109@xxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Mon, 28 Feb 2005 09:12:52 -0800
Stephen Hemminger <shemminger@xxxxxxxx> wrote:

> The original sk98lin attempted to receive hardware checksumming
> but never actually turned it on.

Because there is a bug in the chip wherein checksums can be
miscalculated.  I forget the details, but I do remember that
you can't enable checksumming safely because of this.

In drivers/net/sk98lin/skcsum.c it mentions this:

 * Note:
 *      There is a bug in the GENESIS ASIC which may lead to wrong checksums.

I know this comment is above the send checksum routine, but I
am pretty sure the bug applies to both directions.

<Prev in Thread] Current Thread [Next in Thread>