| To: | Jon Mason <jdmason@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 2/2] r8169: RTL8169_registers clean-up |
| From: | Francois Romieu <romieu@xxxxxxxxxxxxx> |
| Date: | Mon, 28 Feb 2005 20:59:58 +0100 |
| Cc: | netdev@xxxxxxxxxxx, jgarzik@xxxxxxxxx |
| In-reply-to: | <20050228190444.GA13415@xxxxxxxxxx> |
| References: | <20050228190444.GA13415@xxxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.4.1i |
Jon Mason <jdmason@xxxxxxxxxx> :
> An attempt to clean-up RTL8169_registers and RTL8169_register_content.
> Adjusted tab alignment and converted decimal values to hex.
>
> Applies cleanly to linux-2.6.11-rc4-mm1 and tested on amd64
1 - It does not use bitwise shifts where possible (suggested by Jeff);
2 - It is not consistent (see TxDesc...);
3 - Please write a script to reduce the patch and prove that a typo does
not hide somewhere (yep, I'm lazy). It would take too much testing
to get a complete coverage.
Jeff, how am I supposed to handle cleanups now ? Just say no ? :o)
--
Ueimor
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 1/2] r8169: Jumbo Frames mini-increase, Jon Mason |
|---|---|
| Next by Date: | Re: filtering packtes before OS takes care about them, Asim Shankar |
| Previous by Thread: | [PATCH 2/2] r8169: RTL8169_registers clean-up, Jon Mason |
| Next by Thread: | Re: [PATCH 2/2] r8169: RTL8169_registers clean-up, Jon Mason |
| Indexes: | [Date] [Thread] [Top] [All Lists] |