netdev
[Top] [All Lists]

Re: pppoe and receive checksum offload

To: Stephen Hemminger <shemminger@xxxxxxxx>
Subject: Re: pppoe and receive checksum offload
From: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Date: Mon, 28 Feb 2005 22:39:38 +1100
Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>, mostrows@xxxxxxxxxxxxx, Alexey Kuznetsov <kuznet@xxxxxxxxxxxxx>, netdev@xxxxxxxxxxx
In-reply-to: <20050228113106.GA3268@xxxxxxxxxxxxxxxxxxx>
References: <20050224155906.73890361@xxxxxxxxxxxxxxxxx> <20050228113106.GA3268@xxxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.6+20040907i
On Mon, Feb 28, 2005 at 10:31:06PM +1100, herbert wrote:
> 
> In fact it looks like the current code in ip_gre is broken
> in this respect as well.

Actually ip_gre is probably right.  It seems that CHECKSUM_UNNECESSARY
should not be set for PPPOE/GRE packets at all.  So it would be a bug in
the sk* driver.

Alexey/Dave, is this interpretation of ip_summed correct?

Of course we still need to fix up CHECKSUM_HW in pppoe.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

<Prev in Thread] Current Thread [Next in Thread>