netdev
[Top] [All Lists]

Re: [PATCH]: r8169: Expose hardware stats via ethtool

To: Jeff Garzik <jgarzik@xxxxxxxxx>
Subject: Re: [PATCH]: r8169: Expose hardware stats via ethtool
From: Ben Greear <greearb@xxxxxxxxxxxxxxx>
Date: Sun, 27 Feb 2005 20:16:22 -0800
Cc: Jon Mason <jdmason@xxxxxxxxxx>, Richard Dawe <rich@xxxxxxxxxxxxxxxxxxxx>, Francois Romieu <romieu@xxxxxxxxxxxxx>, netdev@xxxxxxxxxxx
In-reply-to: <422288EC.9010502@xxxxxxxxx>
Organization: Candela Technologies
References: <42208D83.80803@xxxxxxxxxxxxxxxxxxxx> <20050226181213.GA13230@xxxxxxxxxxxxxxxxxxxxxxxxxx> <42224F76.9000602@xxxxxxxxxxxxxxxxxxxx> <200502272031.12291.jdmason@xxxxxxxxxx> <422288EC.9010502@xxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.7.3) Gecko/20041020
Jeff Garzik wrote:
Jon Mason wrote:

I think I've found a (very hackish) way around the bad stats error. Tested on amd64, and "solves" the problem.


Seems to me, we should instead find a way to avoid calling the stats function if !netif_running()

Are the stats valid in the hardware if you start it, stop it, and then read 
them?

Ben

--
Ben Greear <greearb@xxxxxxxxxxxxxxx>
Candela Technologies Inc  http://www.candelatech.com


<Prev in Thread] Current Thread [Next in Thread>