Re: [XFRM]: Fix ICMP tempsel

[Patrick McHardy <kaber@xxxxxxxxx>]

Herbert Xu wrote:

> I know this comment is probably a bit late but why didn't we simply put
> type/code into sport/dport in struct flowi instead of introducing the
> monstrosities of xfrm_flowi_sport/xfrm_flowi_dport?
>
> Something like
>
> struct {
>         __u16   type;
>         __u16   code;
> } icmpt;
>
> would've done (and still would do) the trick, no?
I agree, that is better.

Regards
Patrick