netdev
[Top] [All Lists]

Re: [XFRM]: Fix ICMP tempsel

To: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [XFRM]: Fix ICMP tempsel
From: Patrick McHardy <kaber@xxxxxxxxx>
Date: Sat, 19 Feb 2005 19:55:36 +0100
Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>, Maillist netdev <netdev@xxxxxxxxxxx>
In-reply-to: <20050219184351.GB10773@xxxxxxxxxxxxxxxxxxx>
References: <4217266F.6090700@xxxxxxxxx> <20050219184351.GB10773@xxxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.7.5) Gecko/20050106 Debian/1.7.5-1
Herbert Xu wrote:

I know this comment is probably a bit late but why didn't we simply put
type/code into sport/dport in struct flowi instead of introducing the
monstrosities of xfrm_flowi_sport/xfrm_flowi_dport?

Something like

struct {
        __u16   type;
        __u16   code;
} icmpt;

would've done (and still would do) the trick, no?

I agree, that is better.

Regards
Patrick


<Prev in Thread] Current Thread [Next in Thread>