netdev
[Top] [All Lists]

Re: [patch 2.6.11-rc3 5/5] r8169: synchronization and balancing when the

To: Francois Romieu <romieu@xxxxxxxxxxxxx>
Subject: Re: [patch 2.6.11-rc3 5/5] r8169: synchronization and balancing when the device is closed
From: Jon Mason <jdmason@xxxxxxxxxx>
Date: Mon, 14 Feb 2005 11:16:54 -0600
Cc: Jeff Garzik <jgarzik@xxxxxxxxx>, akpm@xxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20050211234522.GD13644@xxxxxxxxxxxxxxxxxxxxxxxxxx>
Organization: IBM
References: <20050211233918.GB8792@xxxxxxxxxxxxxxxxxxxxxxxxxx> <20050211234403.GC13644@xxxxxxxxxxxxxxxxxxxxxxxxxx> <20050211234522.GD13644@xxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: KMail/1.7.2
[...]
> @@ -2399,6 +2398,8 @@ static int rtl8169_close(struct net_devi
>  
>   free_irq(dev->irq, dev);
>  
> + netif_poll_enable(dev);
> +
>   pci_free_consistent(pdev, R8169_RX_RING_BYTES, tp->RxDescArray,
>         tp->RxPhyAddr);
>   pci_free_consistent(pdev, R8169_TX_RING_BYTES, tp->TxDescArray,
> 
> _

Dumb question....Why is this needed?  dev_close has already checked for the 
bit before it calls the rtl8169_close routine (and it was already ripped out 
by netif_poll_disable in rtl8169_down).  

-- 
Jon Mason
jdmason@xxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>