Re: 2.6.10 TCP troubles -- suggested patch

[Alexey Kuznetsov <kuznet@xxxxxxxxxxxxx>]

Hello!

> set it to?  I think correct value is TCP_SKB_CB(skb)->end_seq.

Yup. But it does not matter. When it is not advanced, it does not make
PSHs more rare.

Actually, that anti-MacOS never worked well. If segment with forced PSH
was not transmitted in time, even forced PSHs could be deleted.
Your patch with setting PSH right before (or in) tcp_transmit_skb() must
work. Unless these segments are not tso.


> > I.e. let's disable TSO in 2.6.9 and look.
> 
> I believe this experiment had been performed already.

I saw only tests with TSO. And 2.6.9 showed exactly the same weird
behaviour. Only 2.6.9 did not slow start and we had only a few of 200msec
gaps.

Alexey