netdev
[Top] [All Lists]

Re: [PATCH] Add audit uid to netlink credentials

To: Alexey Kuznetsov <kuznet@xxxxxxxxxxxxx>
Subject: Re: [PATCH] Add audit uid to netlink credentials
From: Alexey Kuznetsov <kuznet@xxxxxxxxxxxxx>
Date: Wed, 9 Feb 2005 19:49:29 +0300
Cc: Stephen Smalley <sds@xxxxxxxxxxxxxx>, Linux Audit Discussion <linux-audit@xxxxxxxxxx>, "Serge E. Hallyn" <serue@xxxxxxxxxx>, netdev@xxxxxxxxxxx, davem@xxxxxxxxxxxxx
Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=ms2.inr.ac.ru; b=qq4IXgwPd3IzlWGhnenAzjGa2ndGcHXvZ8ZQLEmr5EKXCS36ao1pZLdstWMxZZ3WVDyax47a/ZPlFibKm+tV87zqYkwNHnaFSLnzqh3st//2YyqFXzElFfamDn6r+YXl9BcNzQeV86m1EnywvjaEsT8oQHBDd6Yt2SqrhdfPkQo=;
In-reply-to: <20050209141945.GA28864@xxxxxxxxxxxxxxx>
References: <20050204165840.GA2320@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> <Pine.LNX.4.62.0502080658310.32526@xxxxxxxxxxxxxxxxxx> <1107956079.17568.42.camel@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20050209141945.GA28864@xxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.6i
Hello!

> if (down_trylock(&audit_netlink_sem))
>       return;
> 
> with plain down(&audit_netlink_sem);

I am sorry, this is wrong. Dequeue may happen in another process context
in any case.

Alexey

<Prev in Thread] Current Thread [Next in Thread>