netdev
[Top] [All Lists]

Re: [PATCH] NETLINK: Use SKB_MAXORDER to calculate NLMSG_GOODSIZE

To: "David S. Miller" <davem@xxxxxxxxxxxxx>
Subject: Re: [PATCH] NETLINK: Use SKB_MAXORDER to calculate NLMSG_GOODSIZE
From: Thomas Graf <tgraf@xxxxxxx>
Date: Sun, 6 Feb 2005 19:54:17 +0100
Cc: netdev@xxxxxxxxxxx
In-reply-to: <20050128230327.GV31837@xxxxxxxxxxxxxx>
References: <20050128230327.GV31837@xxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
> NLMSG_GOODSIZE specifies a good default size for the skb tailroom
> used in netlink messages when the size is unknown at the time of
> the allocation.
> 
> The current value doesn't make much sense anymore because
> skb_shared_info isn't taken into account which means that
> depending on the architecture NLMSG_GOOSIZE can exceed PAGE_SIZE
> resulting in a waste of almost a complete page.
> 
> Using SKB_MAXORDER solves this potential leak at the cost of
> slightly smaller but safer sizes for some architectures.
> 
> Signed-off-by: Thomas Graf <tgraf@xxxxxxx>

Dave, did you get this one?

<Prev in Thread] Current Thread [Next in Thread>