netdev
[Top] [All Lists]

Re: [Linux-ATM-General] [RFC][PATCH] Very basic sysfs support for ATM de

To: Roman Kagan <rkagan@xxxxxxx>
Subject: Re: [Linux-ATM-General] [RFC][PATCH] Very basic sysfs support for ATM devices (updated)
From: "chas williams - CONTRACTOR" <chas@xxxxxxxxxxxxxxxx>
Date: Sat, 05 Feb 2005 20:33:18 -0500
Cc: netdev@xxxxxxxxxxx, linux-atm-general@xxxxxxxxxxxxxxxxxxxxx, usbatm@xxxxxxxxxxxxxxxxxxx
In-reply-to: Your message of "Fri, 04 Feb 2005 23:13:27 +0300." <20050204201327.GA2439@katya>
Reply-to: chas3@xxxxxxxxxxxxxxxxxxxxx
Reply-to: chas3@xxxxxxxxxxxxxxxxxxxxx
Sender: netdev-bounce@xxxxxxxxxxx
In message <20050204201327.GA2439@katya>,Roman Kagan writes:
>> +static CLASS_DEVICE_ATTR(address, S_IRUGO, show_address, NULL);
>Maybe it should better be "esi", to match the name in struct atm_dev?

its called address for ethernet network interfaces so i guess calling
it address here is sensible.

>script, and hoping that was enough for the driver to complete
>initializing atm_dev.  I suspect the only way to fix it is to split the
>atm_dev initialization into two stages, allocation and registration, as
>it is done for net_device.

yeah which is why i just wanted to convert atm_dev to just be a netdevice.
the code is already written and "stable".

<Prev in Thread] Current Thread [Next in Thread>