netdev
[Top] [All Lists]

Re: [PATCH 2.6.11 PKT_SCHED]: ipt action: add back pskb_expand_head call

To: "David S. Miller" <davem@xxxxxxxxxxxxx>
Subject: Re: [PATCH 2.6.11 PKT_SCHED]: ipt action: add back pskb_expand_head call
From: Patrick McHardy <kaber@xxxxxxxxx>
Date: Fri, 04 Feb 2005 05:09:39 +0100
Cc: Maillist netdev <netdev@xxxxxxxxxxx>
In-reply-to: <4202E7BE.6050606@xxxxxxxxx>
References: <4202E7BE.6050606@xxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.7.5) Gecko/20050106 Debian/1.7.5-1
Patrick McHardy wrote:

Hi Dave,

Jamal asked me to add back the call to pskb_expand_head before 2.6.11.
This fixes a regression caused by my tc action cleanup patches, the
tc actions most not replace packets, so it must prevent netfilter from
doing so.


I forgot the Signed-off-by line, sorry:

Signed-off-by: Patrick McHardy <kaber@xxxxxxxxx>

------------------------------------------------------------------------

===== net/sched/ipt.c 1.13 vs edited =====
--- 1.13/net/sched/ipt.c        2005-01-14 05:41:07 +01:00
+++ edited/net/sched/ipt.c      2005-02-04 04:06:45 +01:00
@@ -207,6 +207,11 @@
        struct tcf_ipt *p = PRIV(a, ipt);
        struct sk_buff *skb = *pskb;

+       if (skb_cloned(skb)) {
+               if (pskb_expand_head(skb, 0, 0, GFP_ATOMIC))
+                       return TC_ACT_UNSPEC;
+       }
+
        spin_lock(&p->lock);

        p->tm.lastuse = jiffies;


<Prev in Thread] Current Thread [Next in Thread>