| To: | "David S. Miller" <davem@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] arp_queue: serializing unlink + kfree_skb |
| From: | Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> |
| Date: | Fri, 4 Feb 2005 12:55:39 +1100 |
| Cc: | anton@xxxxxxxxx, okir@xxxxxxx, netdev@xxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx |
| In-reply-to: | <20050203172357.670c3402.davem@xxxxxxxxxxxxx> |
| References: | <20050131102920.GC4170@xxxxxxx> <E1CvZo6-0001Bz-00@xxxxxxxxxxxxxxxxxxxxxxxx> <20050203142705.GA11318@xxxxxxxxxxxxxxxxxxxxxxxxxx> <20050203203010.GA7081@xxxxxxxxxxxxxxxxxxx> <20050203141901.5ce04c92.davem@xxxxxxxxxxxxx> <20050203235044.GA8422@xxxxxxxxxxxxxxxxxxx> <20050203164922.2627a112.davem@xxxxxxxxxxxxx> <20050204012053.GA8949@xxxxxxxxxxxxxxxxxxx> <20050203172357.670c3402.davem@xxxxxxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.5.6+20040722i |
On Thu, Feb 03, 2005 at 05:23:57PM -0800, David S. Miller wrote: > > You're absolutely right. Ok, so we do need to change kfree_skb(). > I believe even with the memory barrier, the atomic_read() optimization > is still worth it. atomic ops on sparc64 take a minimum of 40 some odd > cycles on UltraSPARC-III and later, whereas the memory barrier will > take up a single cycle most of the time. OK, here is the patch to do that. Let's get rid of kfree_skb_fast while we're at it since it's no longer used. Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
|
| Previous by Date: | Re: [PATCH] arp_queue: serializing unlink + kfree_skb, David S. Miller |
|---|---|
| Next by Date: | Re: [PATCH] s390: qeth network driver, Jeff Garzik |
| Previous by Thread: | Re: [PATCH] arp_queue: serializing unlink + kfree_skb, David S. Miller |
| Next by Thread: | Re: [PATCH] arp_queue: serializing unlink + kfree_skb, Olaf Kirch |
| Indexes: | [Date] [Thread] [Top] [All Lists] |