netdev
[Top] [All Lists]

Re: [IPV4] Make loopback idev stick around

To: "David S. Miller" <davem@xxxxxxxxxxxxx>
Subject: Re: [IPV4] Make loopback idev stick around
From: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Date: Wed, 16 Feb 2005 21:12:45 +1100
Cc: yoshfuji@xxxxxxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20050215144121.702767c5.davem@davemloft.net>
References: <20050205053030.GA17412@gondor.apana.org.au> <20050205053532.GA17474@gondor.apana.org.au> <20050215144121.702767c5.davem@davemloft.net>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.6+20040722i
On Tue, Feb 15, 2005 at 02:41:21PM -0800, David S. Miller wrote:
> 
> I wish ->notifier_call()'s value was actually checked, we could
> do intelligent things instead of panic()'ing when (for example)
> loopback's idev allocation fails.

Yes I missed the ipv6 module case.  It would be very nice to be able
to return errors there.

Since we initiate the loopback registration from addrconf_init,
perhaps we can get away for the time being by checking the error
there?

Let's also clean up loopback's ipv6 structure in addrconf_cleanup
even though it never happens currently :)

Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Attachment: p
Description: Text document

<Prev in Thread] Current Thread [Next in Thread>