netdev
[Top] [All Lists]

Re: 2.6.10 TCP troubles -- suggested patch

To: Andi Kleen <ak@xxxxxx>
Subject: Re: 2.6.10 TCP troubles -- suggested patch
From: "David S. Miller" <davem@xxxxxxxxxxxxx>
Date: Sat, 12 Feb 2005 11:23:07 -0800
Cc: hubert.tonneau@xxxxxxxxxxxxxx, romieu@xxxxxxxxxxxxx, kuznet@xxxxxxxxxxxxx, niv@xxxxxxxxxx, rick.jones2@xxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <m1fz02f05c.fsf@muc.de>
References: <0525M9211@server5.heliogroup.fr> <20050211150420.74737b2e@dxpl.pdx.osdl.net> <20050211170740.2608419b.davem@davemloft.net> <m1fz02f05c.fsf@muc.de>
Sender: netdev-bounce@xxxxxxxxxxx
On Sat, 12 Feb 2005 13:11:43 +0100
Andi Kleen <ak@xxxxxx> wrote:

> "David S. Miller" <davem@xxxxxxxxxxxxx> writes:
> >
> > I guess this is e1000.  Any e1000 internals experts reading
> > here who can comment on how e1000's TSO engine treats the
> > PSH flag?
> 
> If that is the problem it should be easy to test for. Just
> disable TSO with ethtool -K ethX tso off
> 
> Hubert, does that make the problem go away?

We're testing the new code that sets PSH on every TSO frame.
If we disable TSO, the new code won't be exercised nor tested.
:-)

<Prev in Thread] Current Thread [Next in Thread>