Richard Dawe <rich@xxxxxxxxxxxxxxxxxxxx> :
> Applied to 2.6.11-rc3. It seems to work fine. I've passed ~20GB of data
> at 100Mbps full-duplex with no errors (compared MD5 sums on files). My
So it can be considered that the link detection issue is gone.
Ok, I'll ask Jeff to submit it for mainline.
> data rate test (sftp of Linux kernel source tarball) gave about the same
> data rate as 1.6LK + PHY patch - ~7.1MB/sec.
If this test is (sys) CPU bound, then you should see a difference when
SG and TX csum is enabled.
> It works fine setting the speed & duplex using "ethtool -s eth0 autoneg
> off speed <speed> duplex <duplex>".
Does it stand an 'ethtool -s eth0 autoneg on' after this point ?
> I haven't tested the VLAN or jumbo(ish) frames. Let me know if you'd
> like me to test those too. Although I'm not sure if I can test jumbo
> frames with the equipment I have.
If you can do an extra test, I'd like to know if you can safely bring
the r8169 interface down on your computer once the patch below if applied:
(it should apply correctly on top of you current setup)
> One more thing:
> With 1.6LK + my PHY patch, I see the message "eth0: PHY reset until link
> up" every 5 seconds or so, when there is no Ethernet cable plugged in.
> This is annoying. I think it should only log it once.
Hmmm... One could argue that 1) syslog will cope and 2) the printk level
of the console can be lowered. Some event kamasutra can probably be done
from userspace too so I am a bit reluctant to special case this code
(read as: I'd welcome more requests/complaints).
Is it enough for you if I salt the code with a few netif_msg_xxx() here
and there to control the messages ?