netdev
[Top] [All Lists]

Re: [PATCH 2.6] e100: remove reference to NAPI config option

To: Scott Feldman <sfeldma@xxxxxxxxx>
Subject: Re: [PATCH 2.6] e100: remove reference to NAPI config option
From: Anton Blanchard <anton@xxxxxxxxx>
Date: Tue, 1 Feb 2005 12:43:58 +1100
Cc: jgarzik@xxxxxxxxx, netdev@xxxxxxxxxxx, lunz@xxxxxxxxxxxx
In-reply-to: <1107220952.3366.4.camel@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
References: <1107220952.3366.4.camel@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.6+20040907i
Hi Scott,

> e100 is NAPI all the time, so the Kconfig option is wasting space.

Speaking of NAPI...

We have seen issues with NAPI on ppc64 on various cards in the past.
Its possibly due to missing memory barriers; the interrupt and read of
the interrupt status provide syncronization with DMA on the non NAPI
case. Without this you need to be very careful to order reads (eg
between reading the ring status and the packet data).

Anton

<Prev in Thread] Current Thread [Next in Thread>