netdev
[Top] [All Lists]

Re: Memory leak in 2.6.11-rc1?

To: herbert@xxxxxxxxxxxxxxxxxxx, davem@xxxxxxxxxxxxx
Subject: Re: Memory leak in 2.6.11-rc1?
From: YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@xxxxxxxxxxxxxx>
Date: Mon, 31 Jan 2005 13:45:59 +0900 (JST)
Cc: kaber@xxxxxxxxx, rmk+lkml@xxxxxxxxxxxxxxxx, Robert.Olsson@xxxxxxxxxxx, akpm@xxxxxxxx, torvalds@xxxxxxxx, alexn@xxxxxxxxx, kas@xxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx, yoshfuji@xxxxxxxxxxxxxx
In-reply-to: <E1CvSuS-00056x-00@xxxxxxxxxxxxxxxxxxxxxxxx>
Organization: USAGI Project
References: <41FD2043.3070303@xxxxxxxxx> <E1CvSuS-00056x-00@xxxxxxxxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
In article <E1CvSuS-00056x-00@xxxxxxxxxxxxxxxxxxxxxxxx> (at Mon, 31 Jan 2005 
15:11:32 +1100), Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> says:

> Patrick McHardy <kaber@xxxxxxxxx> wrote:
> > 
> > Ok, final decision: you are right :) conntrack also defragments locally
> > generated packets before they hit ip_fragment. In this case the fragments
> > have skb->dst set.
> 
> Well caught.  The same thing is needed for IPv6, right?

(not yet confirmed, but) yes, please.

Signed-off-by: Hideaki YOSHIFUJI <yoshfuji@xxxxxxxxxxxxxx>

===== net/ipv6/ip6_output.c 1.82 vs edited =====
--- 1.82/net/ipv6/ip6_output.c  2005-01-25 09:40:10 +09:00
+++ edited/net/ipv6/ip6_output.c        2005-01-31 13:44:01 +09:00
@@ -463,6 +463,7 @@
        to->priority = from->priority;
        to->protocol = from->protocol;
        to->security = from->security;
+       dst_release(to->dst);
        to->dst = dst_clone(from->dst);
        to->dev = from->dev;
 

--yoshfuji

<Prev in Thread] Current Thread [Next in Thread>