| To: | Thomas Graf <tgraf@xxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] NETLINK: Use SKB_MAXORDER to calculate NLMSG_GOODSIZE |
| From: | Alexey Kuznetsov <kuznet@xxxxxxxxxxxxx> |
| Date: | Sat, 29 Jan 2005 21:40:36 +0300 |
| Cc: | Alexey Kuznetsov <kuznet@xxxxxxxxxxxxx>, Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>, davem@xxxxxxxxxxxxx, netdev@xxxxxxxxxxx |
| Domainkey-signature: | a=rsa-sha1; q=dns; c=nofws; s=s1024; d=ms2.inr.ac.ru; b=dXU/QNIxsaRMTX1Ss4gRQNsUvfYljfYD57g640gaSMtyK+Nibit+u25Q9+nanW2Hv5g+q+MI7XOF51esPCneoGB1mMBNyjk9LHlQpMQfkMTnCJySISt6g8aGaJLa28CEANe0uLUSvE7QAWFP4PdBdLEZryOUZsGSPkJphIruSGw=; |
| In-reply-to: | <20050129002128.GX31837@xxxxxxxxxxxxxx> |
| References: | <20050128230327.GV31837@xxxxxxxxxxxxxx> <E1CufRB-0000zf-00@xxxxxxxxxxxxxxxxxxxxxxxx> <20050128234828.GA24868@xxxxxxxxxxxxxxx> <20050129002128.GX31837@xxxxxxxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.5.6i |
Hello! > alignment though. Can someone enlighten me about the magic 31 in there? It was me who wrote both NLMSG_GOODSIZE and this crap. Does the explanation sound enough? :-) Apparently it was a brainless attempt of formal merge of (broken) NLMSG_GOODSIZE and inversed calculation in alloc_skb. Delete this 31. Alexey |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | How to remove TCP-limits?, Christian Schmid |
|---|---|
| Next by Date: | Re: Linux Routing Performance Update, Florian Weimer |
| Previous by Thread: | Re: [PATCH] NETLINK: Use SKB_MAXORDER to calculate NLMSG_GOODSIZE, Thomas Graf |
| Next by Thread: | Re: [PATCH] NETLINK: Use SKB_MAXORDER to calculate NLMSG_GOODSIZE, Thomas Graf |
| Indexes: | [Date] [Thread] [Top] [All Lists] |