netdev
[Top] [All Lists]

Re: [PATCH] OpenBSD Networking-related randomization port

To: Arjan van de Ven <arjan@xxxxxxxxxxxxx>
Subject: Re: [PATCH] OpenBSD Networking-related randomization port
From: Lorenzo Hernández García-Hierro <lorenzo@xxxxxxx>
Date: Fri, 28 Jan 2005 23:12:49 +0100
Cc: Stephen Hemminger <shemminger@xxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, Chris Wright <chrisw@xxxxxxxx>, netdev@xxxxxxxxxxx, Hank Leininger <hlein@xxxxxxxxxxxxxxxxxxxx>
In-reply-to: <1106945266.7776.41.camel@xxxxxxxxxxxxxxxxxxxxx>
References: <1106932637.3778.92.camel@xxxxxxxxxxxxxxxxxxxxx> <20050128100229.5c0e4ea1@xxxxxxxxxxxxxxxxx> <1106937110.3864.5.camel@xxxxxxxxxxxxxxxxxxxxx> <20050128105217.1dc5ef42@xxxxxxxxxxxxxxxxx> <1106944492.3864.30.camel@xxxxxxxxxxxxxxxxxxxxx> <1106945266.7776.41.camel@xxxxxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
El vie, 28-01-2005 a las 21:47 +0100, Arjan van de Ven escribió:
> as for obsd_get_random_long().. would it be possible to use the
> get_random_int() function from the patches I posted the other day? They
> use the existing random.c infrastructure instead of making a copy...

As seen at
http://www.kernel.org/pub/linux/kernel/people/arjan/execshield/00-randomize-A0 
you can suppose that there's no point to use that, we can easily maintain the 
functions at obsd_rand.c so we wouldn't need to add more maintenance overhead, 
I hope you can understand why I want it like that and not depending on random.c 
in more than the function exports (which make it even more independent as we 
don't need to use our proper header and add each proper include entry in the 
modified files, as most of them use or have already random.h included).

Attached you can find the new patch with the indentation fixes.

The tests on the patch are the following ones:
http://www.osdl.org/plm-cgi/plm?module=patch_info&patch_id=4136
(above one shows that there are no SMP-related issues)
http://khack.osdl.org/stp/300417
http://khack.osdl.org/stp/300420

Cheers and thanks for the information,
-- 
Lorenzo Hernández García-Hierro <lorenzo@xxxxxxx> 
[1024D/6F2B2DEC] & [2048g/9AE91A22][http://tuxedo-es.org]

Attachment: openbsd-netrand-2.6.11-rc2.patch
Description: Text Data

Attachment: signature.asc
Description: Esta parte del mensaje =?ISO-8859-1?Q?est=E1?= firmada digitalmente

<Prev in Thread] Current Thread [Next in Thread>