netdev
[Top] [All Lists]

Re: [PATCH] Tcp port selection for IPV6.

To: Stephen Hemminger <shemminger@xxxxxxxx>
Subject: Re: [PATCH] Tcp port selection for IPV6.
From: "David S. Miller" <davem@xxxxxxxxxxxxx>
Date: Tue, 25 Jan 2005 22:25:08 -0800
Cc: yoshfuji@xxxxxxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20050120164529.6d6a5f0b@xxxxxxxxxxxxxxxxx>
References: <20050120164529.6d6a5f0b@xxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Thu, 20 Jan 2005 16:45:29 -0800
Stephen Hemminger <shemminger@xxxxxxxx> wrote:

> This patch makes TCP over IPV6 select ports the same way the current
> TCPv4 code does. It uses a hash function to provide a starting offset
> and a free running counter to provide seed.
> 
> This changes the port selection semantics to match TCPv4 as well.
> If the port is in use but to a different remote address, it will get
> reused. It looks like the TCPv6 code was not updated when the TCPv4
> code changed. Now the code in ipv4/tcp_ipv4.c and ipv6/tcp_ipv6.c are
> almost identical for tcp_hash_connect.
> 
> Signed-off-by: Stephen Hemminger <shemminger@xxxxxxxx>

Looks good, sorry for taking so long to review.

I think I'll push this into my 2.6.12 pending queue since 2.6.11
is very much in a bug-fix-only type mode.

<Prev in Thread] Current Thread [Next in Thread>