| To: | Thomas Graf <tgraf@xxxxxxx> |
|---|---|
| Subject: | Re: skb_checksum_help |
| From: | Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> |
| Date: | Tue, 25 Jan 2005 13:14:59 +1100 |
| Cc: | "David S. Miller" <davem@xxxxxxxxxxxxx>, david@xxxxxxxxxxxxxxxx, kaber@xxxxxxxxx, netdev@xxxxxxxxxxx |
| In-reply-to: | <20050125014538.GB31837@xxxxxxxxxxxxxx> |
| References: | <E1Cst4o-0007bD-00@xxxxxxxxxxxxxxxxxxxxxxxx> <20050123202715.281ac87c.davem@xxxxxxxxxxxxx> <20050124121610.GP23931@xxxxxxxxxxxxxx> <41F50B6C.6010107@xxxxxxxxxxxxxxxx> <20050124151510.GV23931@xxxxxxxxxxxxxx> <20050124225423.GA15405@xxxxxxxxxxxxxxxxxxx> <20050124234515.GA31837@xxxxxxxxxxxxxx> <20050125000759.GA15883@xxxxxxxxxxxxxxxxxxx> <20050124164049.3b939791.davem@xxxxxxxxxxxxx> <20050125014538.GB31837@xxxxxxxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.5.6+20040722i |
On Tue, Jan 25, 2005 at 02:45:38AM +0100, Thomas Graf wrote: > > the router. The only objection I had with this patch was, that I found > it too unlikely that his box wouldn't receive fragmented packets more > often, but as it seems it is really is this simple. Well the BUG() only triggers if skb->csum + 2 > offset, which is not necessarily true for every skb. -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 2.6.10] tg3: Fix TSO for 5750, David S. Miller |
|---|---|
| Next by Date: | Re: skb_checksum_help, Patrick McHardy |
| Previous by Thread: | Re: skb_checksum_help, David S. Miller |
| Next by Thread: | Re: skb_checksum_help, Herbert Xu |
| Indexes: | [Date] [Thread] [Top] [All Lists] |