Re: [PATCH 1/5] sis900 printk audit

[Daniele Venzano <webvenza@xxxxxxxxx>]

On Sat, Jan 22, 2005 at 11:26:40PM +0100, Francois Romieu wrote:
> Daniele Venzano <webvenza@xxxxxxxxx> :
> [...]
> > Index: sis900.c
> > ===================================================================
> > --- a/drivers/net/sis900.c  (revision 83)
> > +++ b/drivers/net/sis900.c  (revision 84)
> [...]
> > @@ -1906,8 +1918,22 @@
> >     strcpy (info->bus_info, pci_name(sis_priv->pci_dev));
> >  }
> >  
> > +static u32 sis900_get_msglevel(struct net_device *net_dev)
> > +{
> > +   struct sis900_private *sis_priv = net_dev->priv;
> 
> s/net_dev->priv/netdev_priv/

I don't understand, what's wrong here ?
Is that a suggestion that I make some global variable or macro to avoid
repeating that declaration in almost every function of the driver ?

-- 
-----------------------------
Daniele Venzano
Web: http://teg.homeunix.org