netdev
[Top] [All Lists]

Re: [XFRM] Probe selected algorithm only

To: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [XFRM] Probe selected algorithm only
From: James Morris <jmorris@xxxxxxxxxx>
Date: Fri, 21 Jan 2005 09:01:41 -0500 (EST)
Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>, <netdev@xxxxxxxxxxx>
In-reply-to: <20050121101938.GA1133@xxxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Fri, 21 Jan 2005, Herbert Xu wrote:

> Hi Dave:
> 
> This patch removes an annoying problem in xfrm_user.  As it is every
> time an SA is added it probes every known algorithm in the universe.
> Now if they all existed it would be OK.  However, for the ones which
> don't actually exist this causes multiple /sbin/modprobe processes to
> be spawned which slows the system down when you're adding hundreds of
> SAs.
> 
> Since we know the type of algorithm required when we're adding a new
> SA, we can get away with only probing the selected algorithms.  This
> is what the following patch does for xfrm_user.
> 
> Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>

Looks good to me.

Signed-off-by: James Morris <jmorris@xxxxxxxxxx>



- James
-- 
James Morris
<jmorris@xxxxxxxxxx>



<Prev in Thread] Current Thread [Next in Thread>