netdev
[Top] [All Lists]

Re: [PATCH 6/9] irda: use sock slab cache

To: jt@xxxxxxxxxx
Subject: Re: [PATCH 6/9] irda: use sock slab cache
From: Arnaldo Carvalho de Melo <acme@xxxxxxxxxxxxxxxx>
Date: Thu, 20 Jan 2005 19:08:06 -0200
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, irda-users@xxxxxxxxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx, Stephen Hemminger <shemminger@xxxxxxxx>
In-reply-to: <20050120172522.GF6839@xxxxxxxxxxxxxxxxxx>
Organization: Conectiva S.A.
References: <41EF11AF.70203@xxxxxxxxxxxxxxxx> <20050120021607.GA11216@xxxxxxxxxxxxxxxxxx> <41EF29BE.2020807@xxxxxxxxxxxxxxxx> <20050120085454.GA31160@xxxxxxxxxxxxx> <41EFC671.6000706@xxxxxxxxxxxxxxxx> <41EFCC51.8030700@xxxxxxxxxxxxxxxx> <20050120172522.GF6839@xxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla Thunderbird 1.0 (X11/20041220)
Jean Tourrilhes escreveu:
On Thu, Jan 20, 2005 at 01:20:49PM -0200, Arnaldo Carvalho de Melo wrote:
 >>Take a look at this patch, it shows how I think the transitional
stage should be, the protocols will just use (IRDA for the example):


        Can't we just transition IrDA sockets to "future", rather than
"transitional". This way we are done, and no longer need to worry
about it. I mean, you already did the patch, so what's the reason of
holding back ?

No, no reason, this latest scheme is good to balance the needs of
performance protocols critical protocols (tcp, etc) and the ones
where the overhead of a private slabcache is too much, the transitional
solution is just to keep the "old protocols", i.e. the ones not
converted yet, working for the time being. IRDA, from what we
discussed, will be converted today to its final form, that is,
without an slab cache, aggregate kmalloc at sk_alloc time, not using
anymore the generic "sock" slab.

- Arnaldo

<Prev in Thread] Current Thread [Next in Thread>