| To: | Arnaldo Carvalho de Melo <acme@xxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 6/9] irda: use sock slab cache |
| From: | Jean Tourrilhes <jt@xxxxxxxxxx> |
| Date: | Wed, 19 Jan 2005 18:16:07 -0800 |
| Address: | HP Labs, 1U-17, 1501 Page Mill road, Palo Alto, CA 94304, USA. |
| Cc: | "David S. Miller" <davem@xxxxxxxxxxxxx>, irda-users@xxxxxxxxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx, Stephen Hemminger <shemminger@xxxxxxxx> |
| E-mail: | jt@xxxxxxxxxx |
| In-reply-to: | <41EF11AF.70203@xxxxxxxxxxxxxxxx> |
| Organisation: | HP Labs Palo Alto |
| References: | <41EF11AF.70203@xxxxxxxxxxxxxxxx> |
| Reply-to: | jt@xxxxxxxxxx |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.3.28i |
On Thu, Jan 20, 2005 at 12:04:31AM -0200, Arnaldo Carvalho de Melo wrote:
> Hi David, Jean,
>
> Please read the log in the patch.
>
> Regards,
>
> - Arnaldo
>
> ===================================================================
>
>
> ChangeSet@xxxxxx, 2005-01-19 23:04:52-02:00, acme@xxxxxxxxxxxxxxxxxxxxxx
> [IRDA] use a private slab cache for socks
>
> Required to get rid of sk_protinfo and to introduce struct connection_sock,
> also for consistency with other protocol families implementations.
I don't have anything against this patch, as it looks clean
and straightforward. Stephen might have something to say. I'm way
behind, so it may take a while before I test that.
I'm just curious about the overhead of adding a specific slab
for IrDA sockets. Most users never create any (using IrCOMM), or
maximum one (using Obex), so it's not like it will get a lot of use
(except here, of course).
Thanks, and have fun...
Jean
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH 9/9] llc: use sock slab cache, Arnaldo Carvalho de Melo |
|---|---|
| Next by Date: | Re: [PATCH]: was Re: LLTX and netif_stop_queue, Andi Kleen |
| Previous by Thread: | [PATCH 6/9] irda: use sock slab cache, Arnaldo Carvalho de Melo |
| Next by Thread: | Re: [PATCH 6/9] irda: use sock slab cache, Arnaldo Carvalho de Melo |
| Indexes: | [Date] [Thread] [Top] [All Lists] |