netdev
[Top] [All Lists]

Re: sis900: eth0: NULL pointer encountered in Rx ring, skipping

To: Lennert Buytenhek <buytenh@xxxxxxxxxxxxxx>
Subject: Re: sis900: eth0: NULL pointer encountered in Rx ring, skipping
From: Eric Lemoine <eric.lemoine@xxxxxxxxx>
Date: Wed, 19 Jan 2005 21:52:35 +0100
Cc: netdev@xxxxxxxxxxx
Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:references; b=Wu4DpUISkV25XOqBNLHEHvKbO1VqwyOfYqoN9oseHUQk6m/GR9IwEe+b89o4hu+X/olYzu2rpWjii4IUXlKVu7Xw/mjd/Otw6uaHRks4wbyreDXsHdtA30RHoJrF0B24uNBAKutzpI5NUv8xJZo4LZBkymv8mU5cKG8Fu1U/nUM=
In-reply-to: <20050118102139.GA9507@xxxxxxxxxxxxxxxxx>
References: <20050118101358.GA9335@xxxxxxxxxxxxxxxxx> <20050118102139.GA9507@xxxxxxxxxxxxxxxxx>
Reply-to: Eric Lemoine <eric.lemoine@xxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Tue, 18 Jan 2005 11:21:39 +0100, Lennert Buytenhek
<buytenh@xxxxxxxxxxxxxx> wrote:
> On Tue, Jan 18, 2005 at 11:13:58AM +0100, Lennert Buytenhek wrote:
> 
> > I can make one of my machines, which has an on-board sis900 NIC, lose
> > network connectivity within seconds by doing something like
> > "nc -l -p 6666 > /dev/null" and then blasting some data towards it.  When
> > this happens, syslog fills up with these messages:
> >
> >       eth0: NULL pointer encountered in Rx ring, skipping
> 
> Just before it starts spewing these it says:
> 
>         eth0: Memory squeeze,deferring packet.
> 
> So apparently it just doesn't deal with OOM very well.

There are dev_alloc_skb()'s failing due to memory shortage. I think
anyhow that the sis9000 driver doesnt handle "memory squeeze"
situations right. Why not throwing current rx packet away and reuse
ring entry instead of leaving holes (null skb's) in the ring. I would
suggest a patch to the sis900 driver around that attached.

Warning: patch compiling but untested - dont have hardware handy.  

-- 
Eric

Attachment: sis900.patch
Description: Binary data

<Prev in Thread] Current Thread [Next in Thread>