Re: More tc action mess

[Patrick McHardy <kaber@xxxxxxxxx>]

jamal wrote:

> On Wed, 2005-01-19 at 00:09, Patrick McHardy wrote:
>  
>
> > This means we must convert all paths on which tcf_action_exec is called
> > to use struct sk_buff ** :(
> >    
>
> No, just restore the code that you took out in one of your patches
> right above that line which reads:
>
> ----
>        if (skb_cloned(skb)) {
>                if (pskb_expand_head(skb, 0, 0, GFP_ATOMIC)) {
>                        return -1;
>                }
>        }
> ----
>
> Depending on what you do in netfilter lately, you may wanna take out
> the skb_cloned() call.
>  
This does not help. Netfilter calls skb_ip_make_writable if it has to
touch the packet, if it is shared or cloned the packet will be copied.
Despite this, this is hardly a fix as long as the ->act function takes
a struct sk_buff **.

Regards
Patrick