| To: | kumarkr@xxxxxxxxxx |
|---|---|
| Subject: | Re: [Ipoverib] [PATCH] IPv6: Add correct padding to IPoIB link addr option |
| From: | YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@xxxxxxxxxxxxxx> |
| Date: | Wed, 19 Jan 2005 18:02:12 +0900 (JST) |
| Cc: | davem@xxxxxxxxxxxxx, netdev@xxxxxxxxxxx, openib-general@xxxxxxxxxx, roland@xxxxxxxxxxx, yoshfuji@xxxxxxxxxxxxxx |
| In-reply-to: | <OF89EA98A0.9BCDAC57-ON87256F8E.00204D4F-65256F8E.002B4CC8@xxxxxxxxxx> |
| Organization: | USAGI Project |
| References: | <20050119.092018.07351674.yoshfuji@xxxxxxxxxxxxxx> <OF89EA98A0.9BCDAC57-ON87256F8E.00204D4F-65256F8E.002B4CC8@xxxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
In article <OF89EA98A0.9BCDAC57-ON87256F8E.00204D4F-65256F8E.002B4CC8@xxxxxxxxxx> (at Wed, 19 Jan 2005 13:19:55 +0530), Krishna Kumar <kumarkr@xxxxxxxxxx> says: > Couple of minor comments on this : : > 3. I guess there is no clean way to avoid changing all consumers of ll_addr > to not worry > about the padding after the length and before the LL address, but it > would be nice if > that were possible (eg via the ndisc_parse_options). > > Also, Dave/Yoshifuji, can't ndisc_options have just nd_opt_array[5] instead > of nd_opt_array[7], > with indices-1 being used to store/access the options ? In any case, I was > expecting 6 rather > than 7 in the current code, since there are 5 options with the array[0] > being unused. > I'll take care of both. Thank you! --yoshfuji |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH] 3c59x ethtool: provide NIC-specific stats, Steffen Klassert |
|---|---|
| Next by Date: | [2.6 patch] kill xfrm_export.c, Adrian Bunk |
| Previous by Thread: | Re: [Ipoverib] [PATCH] IPv6: Add correct padding to IPoIB link addr option, Vivek Kashyap |
| Next by Thread: | [PATCH][1 of 7][ATM]: [drivers] pci_enable_device() before finding irq, chas williams - CONTRACTOR |
| Indexes: | [Date] [Thread] [Top] [All Lists] |