| To: | "David S. Miller" <davem@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [NETLINK] Do not netlink_unicast shared packet in kernel/audit.c |
| From: | Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> |
| Date: | Tue, 18 Jan 2005 10:11:28 +1100 |
| Cc: | tommy.christensen@xxxxxxxxx, simon.roscic@xxxxxxxxx, netdev@xxxxxxxxxxx |
| In-reply-to: | <20050117133640.0405d791.davem@xxxxxxxxxxxxx> |
| References: | <E1Cpo1q-0007lI-00@xxxxxxxxxxxxxxxxxxxxxxxx> <41E942AF.3030202@xxxxxxxxx> <20050115183023.GA31211@xxxxxxxxxxxxxxxxxxx> <41E97B1A.30205@xxxxxxxxx> <20050116080254.GA2997@xxxxxxxxxxxxxxxxxxx> <20050117133640.0405d791.davem@xxxxxxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.5.6+20040722i |
On Mon, Jan 17, 2005 at 01:36:40PM -0800, David S. Miller wrote: > > I think this patch is buggy. At least in the final hunk, we > do this: > > info.skb = skb; > ... > skb = netlink_trim( ... ); > > Now info.skb can be pointing to a freed up skb. Doh! Here is the corrected version. Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Thanks Dave. -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
|
| Previous by Date: | Re: [PATCH] ipv6: alternative version of S/390 shared NIC support, jamal |
|---|---|
| Next by Date: | Re: [PATCH] ipv6: alternative version of S/390 shared NIC support, Christian Bornträger |
| Previous by Thread: | Re: [NETLINK] Do not netlink_unicast shared packet in kernel/audit.c, David S. Miller |
| Next by Thread: | Re: [NETLINK] Do not netlink_unicast shared packet in kernel/audit.c, David S. Miller |
| Indexes: | [Date] [Thread] [Top] [All Lists] |