netdev
[Top] [All Lists]

Re: [PATCH] ipv6: alternative version of S/390 shared NIC support

To: Christoph Hellwig <hch@xxxxxx>
Subject: Re: [PATCH] ipv6: alternative version of S/390 shared NIC support
From: "David S. Miller" <davem@xxxxxxxxxxxxx>
Date: Mon, 17 Jan 2005 13:42:28 -0800
Cc: pavlic@xxxxxxxxxx, waldi@xxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20050116115431.GA13617@xxxxxx>
References: <20050116115431.GA13617@xxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Sun, 16 Jan 2005 12:54:31 +0100
Christoph Hellwig <hch@xxxxxx> wrote:

> Let's try again solvign the EUI64 generation for S/390.  I looked over
> the IBM patch and I think it can be done a lot simpler:
> 
>  - put a dev_id field in struct net_device, so that it uses space that
>    would be wasted by padding otherwise.
>  - if this fields is non-null let ipv6_generate_eui64 use the algorithm
>    from the QETH code to generate an EUI that's different for each
>    OS instance.  See code comments for details.

I'll apply this patch.

It might be nice to genericize that huge comment.  This will likely
be not the last time we see devices which have this characteristic.

<Prev in Thread] Current Thread [Next in Thread>