netdev
[Top] [All Lists]

Re: [RFC] batched tc to improve change throughput

To: jamal <hadi@xxxxxxxxxx>
Subject: Re: [RFC] batched tc to improve change throughput
From: Thomas Graf <tgraf@xxxxxxx>
Date: Mon, 17 Jan 2005 17:56:26 +0100
Cc: Patrick McHardy <kaber@xxxxxxxxx>, Stephen Hemminger <shemminger@xxxxxxxx>, netdev@xxxxxxxxxxx
In-reply-to: <1105979807.1078.16.camel@xxxxxxxxxxxxxxxx>
References: <20050117152312.GC26856@xxxxxxxxxxxxxx> <1105976711.1078.1.camel@xxxxxxxxxxxxxxxx> <20050117160539.GD26856@xxxxxxxxxxxxxx> <1105979807.1078.16.camel@xxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
* jamal <1105979807.1078.16.camel@xxxxxxxxxxxxxxxx> 2005-01-17 11:36
> On Mon, 2005-01-17 at 11:05, Thomas Graf wrote:
> > * jamal <1105976711.1078.1.camel@xxxxxxxxxxxxxxxx> 2005-01-17 10:45
> > > You dont like the -batch option to tc? ;->
> > 
> > No, because:
> > 
> >  - it duplicates logic
> 
> Didnt follow this - uses the same code as command line. What logic gets
> duplicated?

The parsing of top level nodes.

> >  - it doesn't allow any commenting
> 
> Trivial thing you can fix in about 33.5 seconds ;-

Simple full-line comments yes, mid-line comments no. -batch
is also not able to split things across multiple lines.

I want my scripts to look like this:

/**
 * filter dla_fp
 * match DLA traffic at lower watermark
 */
tc filter add
        dev %DEV
        parent 1:12
        prio 40
        protocol all
        basic match meta(nfmark eq %LOW_WATERMARK)
                    and (
                        nbyte("\x0\x1\x2\x3\x4" at 4 layer 2) /* 00 01 02 03 04 
(dla fp) */
                        or u32(ip src 10.0.0.0/8)
                    )
        flowid 1:20


> >  - it doesn't get along with my more complicated ematch parsing
> 
> Example?

stuff like nbyte, kmp or regexp rely on quoted strings and those
would be destroyed if they'd contain whitespaces.

<Prev in Thread] Current Thread [Next in Thread>