netdev
[Top] [All Lists]

Re: Fwd: [2.6] ethertap and af_inet.c assertion failures

To: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Subject: Re: Fwd: [2.6] ethertap and af_inet.c assertion failures
From: Tommy Christensen <tommy.christensen@xxxxxxxxx>
Date: Sat, 15 Jan 2005 17:19:59 +0100
Cc: simon.roscic@xxxxxxxxx, netdev@xxxxxxxxxxx, davem@xxxxxxxxxxxxx
In-reply-to: <E1Cpo1q-0007lI-00@xxxxxxxxxxxxxxxxxxxxxxxx>
References: <E1Cpo1q-0007lI-00@xxxxxxxxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.2) Gecko/20040803
Herbert Xu wrote:
Since the skb will be orphaned on its way to the destination anyway,
let's simply do that before the trimming.  This shouldn't lead to
skb leakage since the skb will either be charged to the destination
socket or freed.

Looks fine. This will solve the problem for other callers as well.

Shouldn't there be a check for skb_shared as well? Or are the
callers of netlink_unicast/broadcast supposed to avoid this.

-Tommy

<Prev in Thread] Current Thread [Next in Thread>